This change adds a new cleanup mode that avoids cleanup having
re-traverse the directories the index pass just looked at.
Additionally, we efficiently query the Xapian database by walking the
term list instead of doing multiple point-wise path lookups.
I'd noticed that most of my time in mu's cleanup pass consisted of
B-tree lookups in Xapian (one 8KB pread64 at a time). The point
lookups forced Xapian to traverse from the root of the B-tree to the
leaf for every single message. Additionally, in order to join on the
message path, we had to do *another* B-tree traversal after locating
each message term. Now we just walk the terms in order, which is much
more efficient, as we touch each B-tree node only once.
On my system, with 1371861 total messages, the total time of mu
index (no lazy check):
--nocleanup: 3.6s
incremental cleanup: 4.2s (0.6s in cleanup)
legacy cleanup: 5.2s (1.6s in cleanup)
With the new mode, we save 1.0s of the 1.6s cleanup, so we're
~63% faster.
But the incremental cleanup works even better with lazy checking.
If I enable --lazy-check, dirty only my INBOX (360778 messages), and
run index, I get:
--nocleanup: 0.9s
incremental cleanup: 1.1s (0.2s in cleanup)
legacy cleanup: 2.5s (1.6s in cleanup)
We save 1.4s out of 1.6s for ~88% speedup.
This change also fixes a timestamp bug: we should be storing
the *start* time of the index pass in metadata, not the end time, so
that on the next index pass, we notice messages that arrived between
the two times.
All tests pass. You can set the environment variable
MU_NO_INCREMENTAL_CLEANUP to use the legacy cleanup path instead.
mu4e-main-hide-personal-addresses can now also be number, which
indicates the maximum number of personal addresses to show in the main
view.
Remove the 'user-mail-address' tip, perhaps it annoyed more than it
helped?
Instead of macros, we using C++20 concepts to define the helpers to deal with
bitops on enum-class conveniently.
x# Please enter the commit message for your changes. Lines starting
Bump the required versions of some libraries / emacs slightly so we can get rid
of some special-casing and work-arounds. These are mostly based on Ubuntu 24.04
LTS, which is rather conservative; so should hopefully not inconvenience any
users.
- compiler: we now require C++20 instead of C++17
- glib & friends: 2.60 => 2.80
- xapian: 1.4 => 1.4.22
- emacs 26.3 => 28.1
Ubuntu 24.04 actually has Emacs 29.3, but that'd perhaps be too big a jump.
Updates the behavior of `mu4e-view-save-attachments' to allow saving all
attachments. If no files are selected in the completing-read then assume all
files should be downloaded to the selected directory.
Format it consistently with the other man-pages and replace space in "mu scm"
with hyphen to fix mandb(8) handling.
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Troff interprets single quotes at the beginning of lines as control characters.
There is one in the source for mu-labels.1, which results in that line's being
omitted from the output:
The export command takes the labels in the store and the messages they
apply to, and writes this information to a file. You can import this
file later, to restore the labels. The command takes a path to a file or
a directory (ending in
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Even when we're not able to byte-compile some elisp files (mu4e-transient,
mu4e-dbus), we should still install the corresponding el file, as the runtime
emacs may be able to use it.
Issue #2894.
New stable release.
Nothing too spectacular, but a various small tweaks:
- improved guix (and other systems) compatibility: make fewer assumptions about where system programs are
- documentations improvements, in manpages and the mu4e reference manual
- labels: better messages when importing
- scm: stabilize tests. tweaks api.
- mu4e: add mu4e-view-mark-and-next
- mu4e: mu4e-dbus-mode; a new experimental minor in which mu4e exposes some of
its data over DBus.
Some of the tests were using (mfind "") to find messages, but since some
messages don't have dates the order is implicitly defined by the directory
order. This usually works, but not always (i.e. guix).
So let's make the behavior deterministic.
Fixes#2888
Some methods that returned lists would return ~#f~ when there were no
results (e.g., to, from, cc, bcc, references, labels); however, it's
nicer to return an empty list instead, which what we now do. Technically a
breaking change, but justified while we are still 'experimental'.
- don't make assumptions on where programs live (i.e., /bin/sh, /bin/rm,
/bin/mv) are not universal
- dont invoke shell when unnecessary
- improve error-handling
