alx/mu4e
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

mu-store: cosmetics

Browse Source
This commit is contained in:
Dirk-Jan C. Binnema
2026-02-24 19:14:25 +02:00
committed by Seth Ladygo
parent 10067dc95a
commit dc0ad7dabe
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/mu-store.cc
View File

@ -485,6 +485,12 @@ Store::remove_messages_by_term(std::span<const std::string> terms,
} }
// Sort the IDs to remove to make Xapian tree traversal easier // Sort the IDs to remove to make Xapian tree traversal easier
//
// Note: Xapian contractually iterates over terms in ascending
// byte-lexicographic order, so it's only natural to suppose that its
// storage engines in general will get the best locality accessing terms
// in this order. We're allowed to delete in any order we want, so if we
// have to choose an order, this one seems reasonable.
std::ranges::sort(ids_to_remove); std::ranges::sort(ids_to_remove);
for (Id id : ids_to_remove) { for (Id id : ids_to_remove) {
nr_removed += priv_->remove_message_by_id_unlocked(id); nr_removed += priv_->remove_message_by_id_unlocked(id);

11
lib/mu-store.hh
View File

@ -266,14 +266,15 @@ public:
* Remove a number if messages from the store. It will _not_ remove the * Remove a number if messages from the store. It will _not_ remove the
* message from the file system. * message from the file system.
* *
* It's more efficient to use this function than to translate the terms to docids and then * It's more efficient to use this function than to translate the terms
* call remove_messages() with the ids: this way, we can fuse the ID lookup and the * to docids and then call remove_messages() with the ids: this way, we
* deletion, skip post-translation existence steps, and do far fewer Xapian * can fuse the ID lookup and the deletion, skip post-translation
* B-tree traversals. * existence steps, and do far fewer Xapian B-tree traversals.
* *
* @param ids vector with terms for the message * @param terms the terms for the message
* @param progress_fn called occasionally to update number of removed messages; * @param progress_fn called occasionally to update number of removed messages;
* called occasionally with cumulative number of messages removed so far * called occasionally with cumulative number of messages removed so far
*
* @return number of messages removed overall * @return number of messages removed overall
*/ */
size_t remove_messages_by_term(std::span<const std::string> terms, size_t remove_messages_by_term(std::span<const std::string> terms,