alx/mu4e
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* mu-cmd-view.c: refactor to make functions respect 33-lines limit

Browse Source
This commit is contained in:
Dirk-Jan C. Binnema
2010-11-27 14:53:56 +02:00
parent beb84bb5de
commit b200b63a55
1 changed files with 14 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/mu-cmd-view.c
View File

@ -34,20 +34,10 @@
/* we ignore fields for now */ /* we ignore fields for now */
static gboolean static gboolean
view_file (const gchar *path, const gchar *fields, size_t summary_len) view_msg (MuMsg *msg, const gchar *fields, size_t summary_len)
{ {
MuMsg* msg;
const char *field; const char *field;
time_t date; time_t date;
GError *err;
err = NULL;
msg = mu_msg_new (path, NULL, &err);
if (!msg) {
g_warning ("Error: %s", err->message);
g_error_free (err);
return FALSE;
}
if ((field = mu_msg_get_from (msg))) if ((field = mu_msg_get_from (msg)))
g_print ("From: %s\n", field); g_print ("From: %s\n", field);
@ -69,11 +59,6 @@ view_file (const gchar *path, const gchar *fields, size_t summary_len)
g_print ("Summary: %s\n", field ? field : "<none>"); g_print ("Summary: %s\n", field ? field : "<none>");
} else if ((field = mu_msg_get_body_text (msg))) } else if ((field = mu_msg_get_body_text (msg)))
g_print ("\n%s\n", field); g_print ("\n%s\n", field);
else
/* not really an error */
g_debug ("No text body found for %s", path);
mu_msg_destroy (msg);
return TRUE; return TRUE;
} }
@ -93,9 +78,19 @@ mu_cmd_view (MuConfigOptions *opts)
} }
rv = TRUE; rv = TRUE;
for (i = 1; opts->params[i] && rv; ++i) for (i = 1; opts->params[i] && rv; ++i) {
rv = view_file (opts->params[i], NULL,
opts->summary_len); GError *err = NULL;
MuMsg *msg = mu_msg_new (opts->params[i], NULL, &err);
if (!msg) {
g_warning ("Error: %s", err->message);
g_error_free (err);
return FALSE;
}
rv = view_msg (msg, NULL, opts->summary_len);
mu_msg_destroy (msg);
}
return rv; return rv;
} }