alx/mu4e
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

utils/add: improve unit test coverage

Browse Source
This commit is contained in:
Dirk-Jan C. Binnema
2023-09-24 15:49:58 +03:00
parent b0dca49dc0
commit abb0fb4fd5
4 changed files with 36 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/utils/mu-utils.hh
View File

@ -47,7 +47,6 @@
namespace Mu {
/*
* Separator characters used in various places; importantly,
* they are not used in UTF-8
@ -55,7 +54,6 @@ namespace Mu {
constexpr const auto SepaChar1 = '\xfe';
constexpr const auto SepaChar2 = '\xff';
/*
* Logging/printing/formatting functions connect libfmt with the Glib logging
* system. We wrap so perhaps at some point (C++23?) we can use std:: instead.
@ -88,6 +86,7 @@ void mu_warning(fmt::format_string<T...> frm, T&&... args) noexcept {
g_log("mu", G_LOG_LEVEL_WARNING, "%s",
fmt::format(frm, std::forward<T>(args)...).c_str());
}
/* LCOV_EXCL_START*/
template<typename...T>
void mu_critical(fmt::format_string<T...> frm, T&&... args) noexcept {
g_log("mu", G_LOG_LEVEL_CRITICAL, "%s",
@ -98,6 +97,7 @@ void mu_error(fmt::format_string<T...> frm, T&&... args) noexcept {
g_log("mu", G_LOG_LEVEL_ERROR, "%s",
fmt::format(frm, std::forward<T>(args)...).c_str());
}
/* LCOV_EXCL_STOP*/
/*
* Printing; add our wrapper functions, one day we might be able to use std::
@ -355,8 +355,10 @@ struct StopWatch {
StopWatch(const std::string name) : start_{Clock::now()}, name_{name} {}
~StopWatch() {
const auto us{static_cast<double>(to_us(Clock::now() - start_))};
/* LCOV_EXCL_START*/
if (us > 2000000)
mu_debug("sw: {}: finished after {:.1f} s", name_, us / 1000000);
/* LCOV_EXCL_STOP*/
else if (us > 2000)
mu_debug("sw: {}: finished after {:.1f} ms", name_, us / 1000);
else