alx/mu4e
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* mu-msg-iter.cc: cleanup the skip-dup checking a bit; in particular, include

Browse Source 
the first one
This commit is contained in:
djcb
2012-12-24 12:06:09 +02:00
parent c47edd89fd
commit 836c932f2a
1 changed files with 30 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
lib/mu-msg-iter.cc
View File

@ -64,6 +64,9 @@ public:
threads = (flags & MU_MSG_ITER_FLAG_THREADS); threads = (flags & MU_MSG_ITER_FLAG_THREADS);
descending = (flags & MU_MSG_ITER_FLAG_DESCENDING); descending = (flags & MU_MSG_ITER_FLAG_DESCENDING);
_skip_unreadable = (flags & MU_MSG_ITER_FLAG_SKIP_UNREADABLE);
_skip_dups = (flags & MU_MSG_ITER_FLAG_SKIP_DUPS);
/* if we need to calculate threads, initialy get /all/ /* if we need to calculate threads, initialy get /all/
* matches, calculate threads based on that, and then * matches, calculate threads based on that, and then
* return maxnum messages * return maxnum messages
@ -119,15 +122,23 @@ public:
MuMsgIterFlags flags() const { return _flags; } MuMsgIterFlags flags() const { return _flags; }
bool msg_uid_seen_before (const std::string& msg_uid) { bool looks_like_dup () const {
// g_printerr ("%s\n", msg_uid.c_str()); try {
const std::string msg_uid
(cursor().get_document().get_value(MU_MSG_FIELD_ID_MSGID));
if (_msg_uid_set.find (msg_uid) != _msg_uid_set.end()) if (_msg_uid_set.find (msg_uid) != _msg_uid_set.end())
return true; return true;
else { else {
_msg_uid_set.insert (msg_uid); _msg_uid_set.insert (msg_uid);
return false; return false;
} }
} catch (...) {
return true;
} }
}
bool skip_dups () const { return _skip_dups; }
bool skip_unreadable () const { return _skip_unreadable; }
private: private:
const Xapian::Enquire _enq; const Xapian::Enquire _enq;
@ -145,7 +156,9 @@ private:
return g_strcmp0 (s1.c_str(), s2.c_str()) < 0; return g_strcmp0 (s1.c_str(), s2.c_str()) < 0;
} }
}; };
std::set <std::string, ltstr> _msg_uid_set; mutable std::set <std::string, ltstr> _msg_uid_set;
bool _skip_unreadable, _skip_dups;
}; };
@ -182,9 +195,11 @@ mu_msg_iter_new (XapianEnquire *enq, size_t maxnum,
maxnum, maxnum,
sortfield, sortfield,
flags); flags);
if ((flags & MU_MSG_ITER_FLAG_SKIP_UNREADABLE) && // note: we check if it's a dup even for the first message,
!is_msg_file_readable (iter)) // since we need its uid in the set for checking later messages
mu_msg_iter_next (iter); if ((iter->skip_unreadable() && !is_msg_file_readable (iter)) ||
(iter->skip_dups() && iter->looks_like_dup ()))
mu_msg_iter_next (iter); /* skip! */
return iter; return iter;
@ -242,22 +257,6 @@ mu_msg_iter_reset (MuMsgIter *iter)
return TRUE; return TRUE;
} }
static gboolean
msg_seen_before (MuMsgIter *iter)
{
// we *only* consider the msgid; we could also look eg. the
// date, but it seems that Gmail may change the date / time
// zone etc. with still being the same message.
const std::string msg_uid
(iter->cursor().get_document().get_value(MU_MSG_FIELD_ID_MSGID));
// (iter->cursor().get_document().get_value(MU_MSG_FIELD_ID_DATE)));
if (msg_uid.empty())
return FALSE;
else
return iter->msg_uid_seen_before (msg_uid);
}
gboolean gboolean
mu_msg_iter_next (MuMsgIter *iter) mu_msg_iter_next (MuMsgIter *iter)
{ {
@ -274,15 +273,8 @@ mu_msg_iter_next (MuMsgIter *iter)
if (iter->cursor() == iter->matches().end()) if (iter->cursor() == iter->matches().end())
return FALSE; return FALSE;
/* filter out non-existing messages? */ if ((iter->skip_unreadable() && !is_msg_file_readable (iter)) ||
if ((iter->flags() & (iter->skip_dups() && iter->looks_like_dup ()))
MU_MSG_ITER_FLAG_SKIP_UNREADABLE)
&& !is_msg_file_readable (iter))
return mu_msg_iter_next (iter); /*skip!*/
/* filter out msgid duplicates? */
if ((iter->flags() & MU_MSG_ITER_FLAG_SKIP_DUPS) &&
msg_seen_before (iter))
return mu_msg_iter_next (iter); /* skip! */ return mu_msg_iter_next (iter); /* skip! */
return TRUE; return TRUE;