alx/mu4e
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mu4e/server: implement mark-as-read for (view ...)

Browse Source 
Instead of a multi-step process to display an unread message (ie. get
the original, notice it's unread, then update it, replace the message
with update one etc.), we now handle that in the (view /./..) command on
the server side.

Simplifies things, and is faster (which could be noticeable, esp. if
e.g. signature verification is part of the process)
This commit is contained in:
Dirk-Jan C. Binnema
2020-06-10 17:36:38 +03:00
parent cf2e4f1dcd
commit 3dc4b93989
5 changed files with 79 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
mu/mu-cmd-server.cc
View File

@ -1056,11 +1056,9 @@ sent_handler (Context& context, const Parameters& params)
print_expr (std::move(seq));
}
static void
maybe_mark_as_unread (MuMsg *msg, DocId docid)
static bool
maybe_mark_as_read (Mu::Store& store, MuMsg *msg, DocId docid)
{
g_debug ("%s", __func__);
if (!msg)
throw Error{Error::Code::Store, "missing message"};
if (docid == MU_STORE_INVALID_DOCID)
@ -1247,15 +1245,16 @@ make_command_map (Context& context)
cmap.emplace("view",
CommandInfo{
ArgMap{{"docid", ArgInfo{Type::Number, false, "document-id"}},
{"msgid", ArgInfo{Type::String, false, "message-id"}},
{"path", ArgInfo{Type::String, false, "message filesystem path"}},
{"mark-unread", ArgInfo{Type::String, false, "mark message as unread"}},
{"extract-images", ArgInfo{Type::Symbol, false,
ArgMap{{":docid", ArgInfo{Type::Number, false, "document-id"}},
{":msgid", ArgInfo{Type::String, false, "message-id"}},
{":path", ArgInfo{Type::String, false, "message filesystem path"}},
{":mark-as-read", ArgInfo{Type::Symbol, false,
"mark message as read (if not already)"}},
{":extract-images", ArgInfo{Type::Symbol, false,
"whether to extract images for this messages (if any)"}},
{"decrypt", ArgInfo{Type::Symbol, false,
{":decrypt", ArgInfo{Type::Symbol, false,
"whether to decrypt encrypted parts (if any)" }},
{"verify", ArgInfo{Type::Symbol, false,
{":verify", ArgInfo{Type::Symbol, false,
"whether to verify signatures (if any)" }}
},