* crypto: some small updates

TODO

@@ -6,7 +6,7 @@
 
 *** mu
 
-  - handling of signed / encrypted messages
+  - handling of encrypted messages
   - maybe use gstringchunk in mu-msg-cache
   - put threading information in the database, and enable getting the complete
      threads when searching
@@ -51,8 +51,10 @@
      mu4e-view-message-with-msgid)
   - improve mouse interaction (i.e., cursor vs point)
   - add example 'run shellscript on message'
+  - hook up with 'mu verify'
+  - don't show GPG/PKCS7 sigs as attachments
 
-** Done (0.9.9)
+* Done (0.9.9)
 
   - make contacts in the view clickable (toggle long/short display, compose message)
   - opening urls is too eager (now use M-RET for opening url at point, not just
@@ -68,6 +70,11 @@
     certain time (mtime)
   - add mu:timestamp for guile (refering to the message file's mtime)
   - guile automated tests
+  - add 'mu verify'
+    - automated tests
+    - handle verbose/quiet/normal output 'mu verify'
+    - handle pkcs signatures
+    - check gmime 2.4 does not break
 
 * Done
   :PROPERTIES:

configure.ac

@@ -14,7 +14,7 @@
 ## along with this program; if not, write to the Free Software Foundation,
 ## Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 
-AC_INIT([mu],[0.9.9-dev1],[http://code.google.com/p/mu0/issues/list],[mu])
+AC_INIT([mu],[0.9.9-dev2],[http://code.google.com/p/mu0/issues/list],[mu])
 AC_CONFIG_HEADERS([config.h])
 AC_CONFIG_SRCDIR([mu/mu.cc])
 # libtoolize wants to put some stuff in here; if you have an old

man/mu-verify.1

@@ -6,7 +6,7 @@ mu verify\- verify message signatures and display information about them
 
 .SH SYNOPSIS
 
-.B mu verify [options] <file> [<file>*]
+.B mu verify [options] <msgfile>
 
 .SH DESCRIPTION
 
@@ -55,7 +55,7 @@ which does not give any output.
 .SH RETURN VALUE
 
 \fBmu verify\fR returns 0 when all signatures could be verified to be good,
-and returns some non-zero error code when this is not the case
+and returns some non-zero error code when this is not the case.
 
 .nf
 | code | meaning                        |

mu/mu-cmd.c

@@ -481,7 +481,8 @@ mu_cmd_verify (MuConfig *opts, GError **err)
 MuError
 mu_cmd_verify (MuConfig *opts, GError **err)
 {
-	g_warning ("Your version of mu does not support crypto");
+	g_warning ("your version of mu does not support the 'verify' command");
+	return MU_ERROR_IN_PARAMETERS;
 }
 
 #endif /*!BUILD_CRYPTO*/

mu/tests/test-mu-cmd.c

@@ -736,7 +736,7 @@ test_mu_mkdir_01 (void)
 
 /* we can only test 'verify' if gpg is installed, and has
  * djcb@djcbsoftware's key in the keyring */
-static gboolean
+G_GNUC_UNUSED  static gboolean
 verify_is_testable (void)
 {
 	gchar *gpg, *cmdline;
@@ -767,7 +767,7 @@ verify_is_testable (void)
 	return (rv && retval == 0) ? TRUE:FALSE;
 }
 
-static void
+G_GNUC_UNUSED static void
 test_mu_verify_good (void)
 {
         gchar *cmdline;
@@ -788,7 +788,7 @@ test_mu_verify_good (void)
 }
 
 
-static void
+G_GNUC_UNUSED  static void
 test_mu_verify_bad (void)
 {
         gchar *cmdline;
@@ -854,8 +854,10 @@ main (int argc, char *argv[])
 	g_test_add_func ("/mu-cmd/test-mu-view-attach",  test_mu_view_attach);
 	g_test_add_func ("/mu-cmd/test-mu-mkdir-01",  test_mu_mkdir_01);
 
+#ifdef BUILD_CRYPTO
 	g_test_add_func ("/mu-cmd/test-mu-verify-good",  test_mu_verify_good);
 	g_test_add_func ("/mu-cmd/test-mu-verify-bad",  test_mu_verify_bad);
+#endif /*BUILD_CRYPTO*/
 
 	g_log_set_handler (NULL,
 			   G_LOG_LEVEL_MASK | G_LOG_LEVEL_WARNING|