alx/mu4e
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib: move transaction handling to mu-xapian

Browse Source 
Instead of handling transactions in the store, handle it in xapian-db.
Make the code a bit more natural / cleaner-out

Handle transaction automatically (with a batch-size) and add some RAII
Transaction object, which makes all database interaction transactable
for the duration. So, no more need for explicit parameters to
add_message while indexing.
This commit is contained in:
Dirk-Jan C. Binnema
2023-12-13 21:45:04 +02:00
parent cbd6353058
commit 146b80113f
8 changed files with 141 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/mu-store.hh
View File

@ -193,7 +193,7 @@ public:
/**
* Add or update a message to the store. When planning to write many
* messages, it's much faster to do so in a transaction. If so, set
* @in_transaction to true. When done with adding messages, call
* @param in_transaction to true. When done with adding messages, call
* commit().
*
* Optimization: If you are sure the message (i.e., a message with the
@ -202,16 +202,12 @@ public:
* have to check for the existing message.
*
* @param msg a message
* @param use_transaction whether to bundle up to batch_size
* changes in a transaction
* @param is_new whether this is a completely new message
*
* @return the doc id of the added message or an error.
*/
Result<Id> add_message(Message& msg, bool use_transaction = false,
bool is_new = false);
Result<Id> add_message(const std::string& path, bool use_transaction = false,
bool is_new = false);
Result<Id> add_message(Message& msg, bool is_new = false);
Result<Id> add_message(const std::string& path, bool is_new = false);
/**
* Remove a message from the store. It will _not_ remove the message
@ -393,12 +389,6 @@ public:
*/
void set_dirstamp(const std::string& path, time_t tstamp);
/**
* Commit the current batch of modifications to disk, opportunistically.
* If no transaction is underway, do nothing.
*/
void commit();
/*
*
* Some convenience