Made sure \thepage was defined before loading hyperref, as to possibly enable pdfpagelabels=true

2012-10-30 21:06:22 -04:00
parent 36788d3cb8
commit fd54b3d27e
10 changed files with 3 additions and 4 deletions
--- a/examples/template-es.pdf
+++ b/examples/template-es.pdf
--- a/examples/template-zh.pdf
+++ b/examples/template-zh.pdf
--- a/examples/template.pdf
+++ b/examples/template.pdf
--- a/examples/template_banking_black.pdf
+++ b/examples/template_banking_black.pdf
--- a/examples/template_banking_red.pdf
+++ b/examples/template_banking_red.pdf
--- a/examples/template_casual_orange.pdf
+++ b/examples/template_casual_orange.pdf
--- a/examples/template_classic_green.pdf
+++ b/examples/template_classic_green.pdf
--- a/examples/template_multibib.pdf
+++ b/examples/template_multibib.pdf
--- a/examples/template_oldstyle_grey.pdf
+++ b/examples/template_oldstyle_grey.pdf
--- a/moderncv.cls
+++ b/moderncv.cls
@ -123,7 +123,8 @@
 \RequirePackage{url}
 \urlstyle{tt}
 \AtEndPreamble{
-  \RequirePackage[unicode,pdfpagelabels=false]{hyperref}% unicode is required for unicode pdf metadata, pdfpagelabels=false is required to avoid a warning setting it automatically to false anyway, because hyperref detects \thepage as undefined (why?)
+  \pagenumbering{arabic}% has to be issued before loading hyperref, as to set \thepage and hence to avoid hyperref issuing a warning and setting pdfpagelabels=false
+  \RequirePackage[unicode]{hyperref}% unicode is required for unicode pdf metadata
  \hypersetup{
    breaklinks,
    baseurl       = http://,
@ -137,9 +138,7 @@
    pdfauthor     = {\@firstname{}~\@familyname{}},
    pdftitle      = {\@firstname{}~\@familyname{} -- \@title{}},
    pdfsubject    = {Resum\'{e} of \@firstname{}~\@familyname{}},
-    pdfkeywords   = {\@firstname{}~\@familyname{}, curriculum vit\ae{}, resum\'{e}}}
-  \pagenumbering{arabic}% has to be issued after loading hyperref
-}
+    pdfkeywords   = {\@firstname{}~\@familyname{}, curriculum vit\ae{}, resum\'{e}}}}

 % graphics
 \RequirePackage{graphicx}