Removed the use of the suffix package

CHANGELOG

@@ -1,5 +1,6 @@
 version 1.4.0 (dd MMM 2013)
  - deprecated \firstname and \familyname in favour of \name{<first>}{<last>}.
+ - removed the use of the suffix package.
 
 version 1.3.0 (09 Feb 2013)
  - added a new environment to create multiple columns: cvcolumns. Each column
@@ -16,7 +17,7 @@ version 1.3.0 (09 Feb 2013)
  \address to specify a country, as requested on launchpad (launchpad bug
  #1063995).
  - compacted list environments further.
- - replaced the usage of the xargs package by the xparse one.
+ - replaced the use of the xargs package by the xparse one.
 
 version 1.2.1 (04 Dec 2012)
  - fixed a regression bug introduced in version 1.2.0 in the header of the
@@ -70,8 +71,8 @@ version 1.1.0 (29 Jul 2012)
  - changed the handling of the "sans" and "roman" class options, to be reflected
  at the beginning of the document and override style font choices.
  - turned unicode support in hyperref on by default.
- - tweaked the usage of \textbullet to avoid the fall-back to Computer Modern
- fonts and prepared the usage of symbols from the MarVoSym font for fontspec
+ - tweaked the use of \textbullet to avoid the fall-back to Computer Modern
+ fonts and prepared the use of symbols from the MarVoSym font for fontspec
  (LauLaTeX or XeLaTeX).
  - tweaked the \subsectionfill of the "banking" style to distribute extra space
  evenly between leaders.

moderncv.cls

@@ -357,15 +357,12 @@
 
 % makes a resume section
 % usage: \section{<title>}
-\newcommand*{\section}[1]{}
-% starred variant, which is identical but defined to allow its use (e.g. for natbib compatibility, who uses \section*{} for the bibliography header)
-\RequirePackage{suffix}
-\AtBeginDocument{\WithSuffix\newcommand\section*{\section}}
+% identical starred and non-starred variants should be defined for compatibility with other packages (e.g. with natbib, that uses \section*{} for the bibliography header)
+\NewDocumentCommand{\section}{sm}{}
 
 % makes a resume subsection
 % usage: \subsection{title}
-\newcommand*{\subsection}[1]{}
-\AtBeginDocument{\WithSuffix\newcommand\subsection*{\subsection}}
+\NewDocumentCommand{\subsection}{sm}{}
 
 % makes a resume line with a header and a corresponding text
 % usage: \cvitem[spacing]{header}{text}

moderncvstylebanking.sty

@@ -167,20 +167,20 @@
     {{\centering\begin{minipage}{\quotewidth}\centering\quotestyle{\@quote}\end{minipage}\\[2.5em]}}%
   \par}% to avoid weird spacing bug at the first section if no blank line is left after \maketitle}
 
-\renewcommand*{\section}[1]{%
+\RenewDocumentCommand{\section}{sm}{%
   \par\addvspace{2.5ex}%
   \phantomsection{}% reset the anchor for hyperrefs
-  \addcontentsline{toc}{section}{#1}%
-  \strut\sectionstyle{#1}%
+  \addcontentsline{toc}{section}{#2}%
+  \strut\sectionstyle{#2}%
   {\color{color1}\hrule}%
   \par\nobreak\addvspace{1ex}\@afterheading}
 
 \newcommand{\subsectionfill}{\xleaders\hbox to 0.35em{\scriptsize.}\hfill}% different subsectionfills will not be perfectly aligned, but remaining space at the end of the fill will be distributed evenly between leaders, so it will be barely visible
-\renewcommand*{\subsection}[1]{%
+\RenewDocumentCommand{\subsection}{sm}{%
   \par\addvspace{1ex}%
   \phantomsection{}%
-  \addcontentsline{toc}{subsection}{#1}%
-  \strut\subsectionstyle{#1}{\color{color1}{\subsectionfill}}%
+  \addcontentsline{toc}{subsection}{#2}%
+  \strut\subsectionstyle{#2}{\color{color1}{\subsectionfill}}%
   \par\nobreak\addvspace{0.5ex}\@afterheading}
 
 \renewcommand*{\cvitem}[3][.25em]{%

moderncvstyleclassic.sty

@@ -155,27 +155,27 @@
 \newlength{\baseletterheight}
 \settoheight{\baseletterheight}{\sectionstyle{o}}
 \setlength{\baseletterheight}{\baseletterheight-0.95ex}
-\renewcommand*{\section}[1]{%
+\RenewDocumentCommand{\section}{sm}{%
   \par\addvspace{2.5ex}%
   \phantomsection{}% reset the anchor for hyperrefs
-  \addcontentsline{toc}{section}{#1}%
+  \addcontentsline{toc}{section}{#2}%
   \parbox[t]{\hintscolumnwidth}{\strut\raggedleft\raisebox{\baseletterheight}{\color{color1}\rule{\hintscolumnwidth}{0.95ex}}}%
   \hspace{\separatorcolumnwidth}%
-  \parbox[t]{\maincolumnwidth}{\strut\sectionstyle{#1}}%
+  \parbox[t]{\maincolumnwidth}{\strut\sectionstyle{#2}}%
   \par\nobreak\addvspace{1ex}\@afterheading}% to avoid a pagebreak after the heading
 
-\renewcommand*{\subsection}[1]{%
+\RenewDocumentCommand{\subsection}{sm}{%
   \par\addvspace{1ex}%
   \phantomsection{}% reset the anchor for hyperrefs
-  \addcontentsline{toc}{subsection}{#1}%
+  \addcontentsline{toc}{subsection}{#2}%
   \begin{tabular}{@{}p{\hintscolumnwidth}@{\hspace{\separatorcolumnwidth}}p{\maincolumnwidth}@{}}%
- 	  \raggedleft\hintstyle{} &{\strut\subsectionstyle{#1}}%
+    \raggedleft\hintstyle{} &{\strut\subsectionstyle{#2}}%
   \end{tabular}%
   \par\nobreak\addvspace{0.5ex}\@afterheading}% to avoid a pagebreak after the heading
 
 \renewcommand*{\cvitem}[3][.25em]{%
   \begin{tabular}{@{}p{\hintscolumnwidth}@{\hspace{\separatorcolumnwidth}}p{\maincolumnwidth}@{}}%
- 	  \raggedleft\hintstyle{#2} &{#3}%
+    \raggedleft\hintstyle{#2} &{#3}%
   \end{tabular}%
   \par\addvspace{#1}}
 

moderncvstyleoldstyle.sty

@@ -160,18 +160,18 @@
     \ifthenelse{\isundefined{\@homepage}}{}{\makenewline\homepagesymbol\httplink{\@homepage}}%
     \ifthenelse{\isundefined{\@extrainfo}}{}{\makenewline\@extrainfo}}}
 
-\renewcommand*{\section}[1]{%
+\RenewDocumentCommand{\section}{sm}{%
   \par\addvspace{2.5ex}%
   \phantomsection{}% reset the anchor for hyperrefs
-  \addcontentsline{toc}{section}{#1}%
-  \strut\sectionstyle{#1}%
+  \addcontentsline{toc}{section}{#2}%
+  \strut\sectionstyle{#2}%
   \par\nobreak\addvspace{1ex}\@afterheading}% to avoid a pagebreak after the heading
 
-\renewcommand*{\subsection}[1]{%
+\RenewDocumentCommand{\subsection}{sm}{%
   \par\addvspace{1ex}%
   \phantomsection{}% reset the anchor for hyperrefs
-  \addcontentsline{toc}{subsection}{#1}%
-  \strut\subsectionstyle{#1}%
+  \addcontentsline{toc}{subsection}{#2}%
+  \strut\subsectionstyle{#2}%
   \par\nobreak\addvspace{0.5ex}\@afterheading}% to avoid a pagebreak after the heading
 
 \renewcommand*{\cvitem}[3][.25em]{%